Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e1fed98 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Greg Kroah-Hartman
Browse files

usb: gadget: uvc: configfs: Drop leaked references to config items 



[ Upstream commit 86f3daed59bceb4fa7981d85e89f63ebbae1d561 ]

Some of the .allow_link() and .drop_link() operations implementations
call config_group_find_item() and then leak the reference to the
returned item. Fix this by dropping those references where needed.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b197d34b

drivers/usb/gadget/function/uvc_configfs.c

+4 −0
Original line number Diff line number Diff line
@@ -543,6 +543,7 @@ static int uvcg_control_class_allow_link(struct config_item *src, 
unlock:

	mutex_unlock(&opts->lock);

out:

	config_item_put(header);

	mutex_unlock(su_mutex);

	return ret;

}
@@ -578,6 +579,7 @@ static void uvcg_control_class_drop_link(struct config_item *src, 
unlock:

	mutex_unlock(&opts->lock);

out:

	config_item_put(header);

	mutex_unlock(su_mutex);

}
@@ -2037,6 +2039,7 @@ static int uvcg_streaming_class_allow_link(struct config_item *src, 
unlock:

	mutex_unlock(&opts->lock);

out:

	config_item_put(header);

	mutex_unlock(su_mutex);

	return ret;

}
@@ -2077,6 +2080,7 @@ static void uvcg_streaming_class_drop_link(struct config_item *src, 
unlock:

	mutex_unlock(&opts->lock);

out:

	config_item_put(header);

	mutex_unlock(su_mutex);

}