Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d915684 authored by Phong Tran's avatar Phong Tran Committed by Greg Kroah-Hartman
Browse files

rtlwifi: rtl_pci: Fix -Wcast-function-type 

[ Upstream commit cb775c88da5d48a85d99d95219f637b6fad2e0e9 ]

correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20



Signed-off-by: default avatarPhong Tran <tranmanphong@gmail.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b33327e5

drivers/net/wireless/realtek/rtlwifi/pci.c

+6 −4
Original line number Diff line number Diff line
@@ -1082,13 +1082,15 @@ static irqreturn_t _rtl_pci_interrupt(int irq, void *dev_id) 
	return ret;

}



static void _rtl_pci_irq_tasklet(struct ieee80211_hw *hw)

static void _rtl_pci_irq_tasklet(unsigned long data)

{

	struct ieee80211_hw *hw = (struct ieee80211_hw *)data;

	_rtl_pci_tx_chk_waitq(hw);

}



static void _rtl_pci_prepare_bcn_tasklet(struct ieee80211_hw *hw)

static void _rtl_pci_prepare_bcn_tasklet(unsigned long data)

{

	struct ieee80211_hw *hw = (struct ieee80211_hw *)data;

	struct rtl_priv *rtlpriv = rtl_priv(hw);

	struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));

	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
@@ -1214,10 +1216,10 @@ static void _rtl_pci_init_struct(struct ieee80211_hw *hw, 


	/*task */

	tasklet_init(&rtlpriv->works.irq_tasklet,

		     (void (*)(unsigned long))_rtl_pci_irq_tasklet,

		     _rtl_pci_irq_tasklet,

		     (unsigned long)hw);

	tasklet_init(&rtlpriv->works.irq_prepare_bcn_tasklet,

		     (void (*)(unsigned long))_rtl_pci_prepare_bcn_tasklet,

		     _rtl_pci_prepare_bcn_tasklet,

		     (unsigned long)hw);

	INIT_WORK(&rtlpriv->works.lps_change_work,

		  rtl_lps_change_work_callback);