Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d1d1d39 authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller
Browse files

bridge: Fix skb leak when multicast parsing fails on TX 



On the bridge TX path we're leaking an skb when br_multicast_rcv
returns an error.

Reported-by: default avatarDavid Lamparter <equinox@diac24.net>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a3bdb549

net/bridge/br_device.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -48,8 +48,10 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) 




	rcu_read_lock();

	rcu_read_lock();

	if (is_multicast_ether_addr(dest)) {

	if (is_multicast_ether_addr(dest)) {

		if (br_multicast_rcv(br, NULL, skb))

		if (br_multicast_rcv(br, NULL, skb)) {

			kfree_skb(skb);

			goto out;

			goto out;

		}





		mdst = br_mdb_get(br, skb);

		mdst = br_mdb_get(br, skb);

		if (mdst || BR_INPUT_SKB_CB_MROUTERS_ONLY(skb))

		if (mdst || BR_INPUT_SKB_CB_MROUTERS_ONLY(skb))