Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c4a536c authored by Wenwen Wang's avatar Wenwen Wang Committed by Greg Kroah-Hartman
Browse files

ALSA: hda - Fix a memory leak bug 



commit cfef67f016e4c00a2f423256fc678a6967a9fc09 upstream.

In snd_hda_parse_generic_codec(), 'spec' is allocated through kzalloc().
Then, the pin widgets in 'codec' are parsed. However, if the parsing
process fails, 'spec' is not deallocated, leading to a memory leak.

To fix the above issue, free 'spec' before returning the error.

Fixes: 352f7f91 ("ALSA: hda - Merge Realtek parser code to generic parser")
Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1bf5f827

sound/pci/hda/hda_generic.c

+1 −1
Original line number Diff line number Diff line
@@ -6082,7 +6082,7 @@ static int snd_hda_parse_generic_codec(struct hda_codec *codec) 


	err = snd_hda_parse_pin_defcfg(codec, &spec->autocfg, NULL, 0);

	if (err < 0)

		return err;

		goto error;



	err = snd_hda_gen_parse_auto_config(codec, &spec->autocfg);

	if (err < 0)