Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6bf79cdd authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

vmxnet3: use netdev_rss_key_fill() helper 



Use of well known RSS key increases attack surface.
Switch to a random one, using generic helper so that all
ports share a common key.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Shreyas Bhatewara <sbhatewara@vmware.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7a20db37

drivers/net/vmxnet3/vmxnet3_drv.c

+1 −8
Original line number Diff line number Diff line
@@ -2199,13 +2199,6 @@ vmxnet3_setup_driver_shared(struct vmxnet3_adapter *adapter) 


	if (adapter->rss) {

		struct UPT1_RSSConf *rssConf = adapter->rss_conf;

		static const uint8_t rss_key[UPT1_RSS_MAX_KEY_SIZE] = {

			0x3b, 0x56, 0xd1, 0x56, 0x13, 0x4a, 0xe7, 0xac,

			0xe8, 0x79, 0x09, 0x75, 0xe8, 0x65, 0x79, 0x28,

			0x35, 0x12, 0xb9, 0x56, 0x7c, 0x76, 0x4b, 0x70,

			0xd8, 0x56, 0xa3, 0x18, 0x9b, 0x0a, 0xee, 0xf3,

			0x96, 0xa6, 0x9f, 0x8f, 0x9e, 0x8c, 0x90, 0xc9,

		};



		devRead->misc.uptFeatures |= UPT1_F_RSS;

		devRead->misc.numRxQueues = adapter->num_rx_queues;
@@ -2216,7 +2209,7 @@ vmxnet3_setup_driver_shared(struct vmxnet3_adapter *adapter) 
		rssConf->hashFunc = UPT1_RSS_HASH_FUNC_TOEPLITZ;

		rssConf->hashKeySize = UPT1_RSS_MAX_KEY_SIZE;

		rssConf->indTableSize = VMXNET3_RSS_IND_TABLE_SIZE;

		memcpy(rssConf->hashKey, rss_key, sizeof(rss_key));

		netdev_rss_key_fill(rssConf->hashKey, sizeof(rssConf->hashKey));



		for (i = 0; i < rssConf->indTableSize; i++)

			rssConf->indTable[i] = ethtool_rxfh_indir_default(