Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a01d48d authored by Geliang Tang's avatar Geliang Tang Committed by Kalle Valo
Browse files

wlcore: use memdup_user 



Use memdup_user() helper instead of open-coding to simplify the code.

Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 6d7d579a

drivers/net/wireless/ti/wlcore/debugfs.c

+3 −10
Original line number Diff line number Diff line
@@ -1149,15 +1149,9 @@ static ssize_t dev_mem_write(struct file *file, const char __user *user_buf, 
	part.mem.start = *ppos;

	part.mem.size = bytes;



	buf = kmalloc(bytes, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;



	ret = copy_from_user(buf, user_buf, bytes);

	if (ret) {

		ret = -EFAULT;

		goto err_out;

	}

	buf = memdup_user(user_buf, bytes);

	if (IS_ERR(buf))

		return PTR_ERR(buf);



	mutex_lock(&wl->mutex);
@@ -1197,7 +1191,6 @@ static ssize_t dev_mem_write(struct file *file, const char __user *user_buf, 
	if (ret == 0)

		*ppos += bytes;



err_out:

	kfree(buf);



	return ((ret == 0) ? bytes : ret);