Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 687d4f2b authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net: ethernet: slicoss: remove redundant initialization of idx 



Variable idx is being initialized and later on over-written by
a new value in a do-loop without the initial value ever being
read. Hence the initializion is redundant and can be removed.
Cleans up clang warning:

drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
stored to 'idx' during its initialization is never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f631f7bd

drivers/net/ethernet/alacritech/slicoss.c

+1 −1
Original line number Diff line number Diff line
@@ -355,10 +355,10 @@ static void slic_xmit_complete(struct slic_device *sdev) 
{

	struct slic_tx_queue *txq = &sdev->txq;

	struct net_device *dev = sdev->netdev;

	unsigned int idx = txq->done_idx;

	struct slic_tx_buffer *buff;

	unsigned int frames = 0;

	unsigned int bytes = 0;

	unsigned int idx;



	/* Limit processing to SLIC_MAX_TX_COMPLETIONS frames to avoid that new

	 * completions during processing keeps the loop running endlessly.