Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6713e8fb authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

debugfs: Add read-only/write-only bool file ops 



There aren't any read-only or write-only bool file ops, but there
is a caller of debugfs_create_bool() that calls it with mode
equal to 0400. This leads to the possibility of userspace
modifying the file, so let's use the newly created
debugfs_create_mode() helper here to fix this.

Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6db6652a

fs/debugfs/file.c

+14 −1
Original line number Diff line number Diff line
@@ -450,6 +450,18 @@ static const struct file_operations fops_bool = { 
	.llseek =	default_llseek,

};



static const struct file_operations fops_bool_ro = {

	.read =		debugfs_read_file_bool,

	.open =		simple_open,

	.llseek =	default_llseek,

};



static const struct file_operations fops_bool_wo = {

	.write =	debugfs_write_file_bool,

	.open =		simple_open,

	.llseek =	default_llseek,

};



/**

 * debugfs_create_bool - create a debugfs file that is used to read and write a boolean value

 * @name: a pointer to a string containing the name of the file to create.
@@ -477,7 +489,8 @@ static const struct file_operations fops_bool = { 
struct dentry *debugfs_create_bool(const char *name, umode_t mode,

				   struct dentry *parent, bool *value)

{

	return debugfs_create_file(name, mode, parent, value, &fops_bool);

	return debugfs_create_mode(name, mode, parent, value, &fops_bool,

				   &fops_bool_ro, &fops_bool_wo);

}

EXPORT_SYMBOL_GPL(debugfs_create_bool);