Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65f57cb1 authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by David S. Miller
Browse files

amd-xgbe-phy: Use the phy_driver flags field 



Remove the setting of the transceiver type when retrieving the device
settings using ethtool and instead set the transceiver type in the
phy_driver structure flags field. Change the transceiver type to be
internal, also.

Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d9663c8c

drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -291,7 +291,6 @@ static int xgbe_get_settings(struct net_device *netdev, 
		return -ENODEV;

		return -ENODEV;





	ret = phy_ethtool_gset(pdata->phydev, cmd);

	ret = phy_ethtool_gset(pdata->phydev, cmd);

	cmd->transceiver = XCVR_EXTERNAL;





	DBGPR("<--xgbe_get_settings\n");

	DBGPR("<--xgbe_get_settings\n");

drivers/net/phy/amd-xgbe-phy.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -1816,6 +1816,7 @@ static struct phy_driver amd_xgbe_phy_driver[] = { 
		.phy_id_mask		= XGBE_PHY_MASK,

		.phy_id_mask		= XGBE_PHY_MASK,

		.name			= "AMD XGBE PHY",

		.name			= "AMD XGBE PHY",

		.features		= 0,

		.features		= 0,

		.flags			= PHY_IS_INTERNAL,

		.probe			= amd_xgbe_phy_probe,

		.probe			= amd_xgbe_phy_probe,

		.remove			= amd_xgbe_phy_remove,

		.remove			= amd_xgbe_phy_remove,

		.soft_reset		= amd_xgbe_phy_soft_reset,

		.soft_reset		= amd_xgbe_phy_soft_reset,