Commit 65e9e65c authored Mar 14, 2017 by Dan Carpenter Committed by Alexandre Belloni Mar 16, 2017

rtc: cpcap: kfreeing devm allocated memory



We shouldn't kfree(rtc) because is devm_ managed memory.  It leads to a
double free.

Fixes: dd3bf50b ("rtc: cpcap: new rtc driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 7a8128e2

drivers/rtc/rtc-cpcap.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -266,10 +266,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
		rtc->rtc_dev = devm_rtc_device_register(dev, "cpcap_rtc",
		&cpcap_rtc_ops, THIS_MODULE);

		if (IS_ERR(rtc->rtc_dev)) {
		kfree(rtc);
		if (IS_ERR(rtc->rtc_dev))
		return PTR_ERR(rtc->rtc_dev);
		}

		err = cpcap_get_vendor(dev, rtc->regmap, &rtc->vendor);
		if (err)