Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65b80179 authored by Chuck Lever's avatar Chuck Lever Committed by Anna Schumaker
Browse files

xprtrdma: No direct data placement with krb5i and krb5p 



Direct data placement is not allowed when using flavors that
guarantee integrity or privacy. When such security flavors are in
effect, don't allow the use of Read and Write chunks for moving
individual data items. All messages larger than the inline threshold
are sent via Long Call or Long Reply.

On my systems (CX-3 Pro on FDR), for small I/O operations, the use
of Long messages adds only around 5 usecs of latency in each
direction.

Note that when integrity or encryption is used, the host CPU touches
every byte in these messages. Even if it could be used, data
movement offload doesn't buy much in this case.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Tested-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 64695bde

include/linux/sunrpc/auth.h

+3 −0
Original line number Diff line number Diff line
@@ -107,6 +107,9 @@ struct rpc_auth { 
	/* per-flavor data */

};



/* rpc_auth au_flags */

#define RPCAUTH_AUTH_DATATOUCH	0x00000002



struct rpc_auth_create_args {

	rpc_authflavor_t pseudoflavor;

	const char *target_name;

include/linux/sunrpc/gss_api.h

+2 −0
Original line number Diff line number Diff line
@@ -73,6 +73,7 @@ u32 gss_delete_sec_context( 
rpc_authflavor_t gss_svc_to_pseudoflavor(struct gss_api_mech *, u32 qop,

					u32 service);

u32 gss_pseudoflavor_to_service(struct gss_api_mech *, u32 pseudoflavor);

bool gss_pseudoflavor_to_datatouch(struct gss_api_mech *, u32 pseudoflavor);

char *gss_service_to_auth_domain_name(struct gss_api_mech *, u32 service);



struct pf_desc {
@@ -81,6 +82,7 @@ struct pf_desc { 
	u32	service;

	char	*name;

	char	*auth_domain_name;

	bool	datatouch;

};



/* Different mechanisms (e.g., krb5 or spkm3) may implement gss-api, and

net/sunrpc/auth_gss/auth_gss.c

+2 −0
Original line number Diff line number Diff line
@@ -1017,6 +1017,8 @@ gss_create_new(struct rpc_auth_create_args *args, struct rpc_clnt *clnt) 
	auth->au_rslack = GSS_VERF_SLACK >> 2;

	auth->au_ops = &authgss_ops;

	auth->au_flavor = flavor;

	if (gss_pseudoflavor_to_datatouch(gss_auth->mech, flavor))

		auth->au_flags |= RPCAUTH_AUTH_DATATOUCH;

	atomic_set(&auth->au_count, 1);

	kref_init(&gss_auth->kref);

net/sunrpc/auth_gss/gss_krb5_mech.c

+2 −0
Original line number Diff line number Diff line
@@ -745,12 +745,14 @@ static struct pf_desc gss_kerberos_pfs[] = { 
		.qop = GSS_C_QOP_DEFAULT,

		.service = RPC_GSS_SVC_INTEGRITY,

		.name = "krb5i",

		.datatouch = true,

	},

	[2] = {

		.pseudoflavor = RPC_AUTH_GSS_KRB5P,

		.qop = GSS_C_QOP_DEFAULT,

		.service = RPC_GSS_SVC_PRIVACY,

		.name = "krb5p",

		.datatouch = true,

	},

};

net/sunrpc/auth_gss/gss_mech_switch.c

+12 −0
Original line number Diff line number Diff line
@@ -361,6 +361,18 @@ gss_pseudoflavor_to_service(struct gss_api_mech *gm, u32 pseudoflavor) 
}

EXPORT_SYMBOL(gss_pseudoflavor_to_service);



bool

gss_pseudoflavor_to_datatouch(struct gss_api_mech *gm, u32 pseudoflavor)

{

	int i;



	for (i = 0; i < gm->gm_pf_num; i++) {

		if (gm->gm_pfs[i].pseudoflavor == pseudoflavor)

			return gm->gm_pfs[i].datatouch;

	}

	return false;

}



char *

gss_service_to_auth_domain_name(struct gss_api_mech *gm, u32 service)

{