Commit 6561e82d authored Sep 15, 2017 by Meghana Madhyastha Committed by Greg Kroah-Hartman Sep 18, 2017

Staging: irda: drivers: Replace (skb == NULL) with (!skb)



Some functions return NULL as an indication of failure.
The style (!skb) is more common than (skb == NULL) for these
functions.

Found by the following Coccinelle script.

@@
identifier i;
statement S;
@@

i = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\|
alloc_netdev\|dev_alloc_skb\)(...));

(
-if (i == NULL)
+if (!i)
S
|
-if (NULL == i)
+if (!i)
S
)

Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b351fa3c

drivers/staging/irda/drivers/ali-ircc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1876,7 +1876,7 @@ static int ali_ircc_dma_receive_complete(struct ali_ircc_cb *self)
		self->stamp = ktime_get();

		skb = dev_alloc_skb(len+1);
		if (skb == NULL)
		if (!skb)
		{
		self->netdev->stats.rx_dropped++;