Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 655745b0 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Greg Kroah-Hartman
Browse files

VMCI: use memdup_user(). 



Use memdup_user to duplicate a memory region from user-space to
kernel-space, instead of open coding using kmalloc & copy_from_user.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b58189b3

drivers/misc/vmw_vmci/vmci_host.c

+4 −10
Original line number Diff line number Diff line
@@ -381,18 +381,12 @@ static int vmci_host_do_send_datagram(struct vmci_host_dev *vmci_host_dev, 
		return -EINVAL;

	}



	dg = kmalloc(send_info.len, GFP_KERNEL);

	if (!dg) {

	dg = memdup_user((void __user *)(uintptr_t)send_info.addr,

			 send_info.len);

	if (IS_ERR(dg)) {

		vmci_ioctl_err(

			"cannot allocate memory to dispatch datagram\n");

		return -ENOMEM;

	}



	if (copy_from_user(dg, (void __user *)(uintptr_t)send_info.addr,

			   send_info.len)) {

		vmci_ioctl_err("error getting datagram\n");

		kfree(dg);

		return -EFAULT;

		return PTR_ERR(dg);

	}



	if (VMCI_DG_SIZE(dg) != send_info.len) {