Commit 646ebd41 authored Feb 08, 2017 by Leon Romanovsky Committed by Doug Ledford Feb 08, 2017

RDMA: Don't reference kernel private header from UAPI header



Remove references to private kernel header and defines from exported
ib_user_verb.h file.

The code snippet below is used to reproduce the issue:

 #include <stdio.h>
 #include <rdma/ib_user_verb.h>

 int main(void)
 {
	printf("IB_USER_VERBS_ABI_VERSION = %d\n", IB_USER_VERBS_ABI_VERSION);
	return 0;
 }

It fails during compilation phase with an error:
➜  /tmp gcc main.c
main.c:2:31: fatal error: rdma/ib_user_verb.h: No such file or directory
 #include <rdma/ib_user_verb.h>
                               ^
compilation terminated.

Fixes: 189aba99 ("IB/uverbs: Extend modify_qp and support packet pacing")
CC: Bodong Wang <bodong@mellanox.com>
CC: Matan Barak <matanb@mellanox.com>
CC: Christoph Hellwig <hch@infradead.org>
Tested-by: Slava Shwartsman <slavash@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 647bf3d8

include/uapi/rdma/ib_user_verbs.h

+8 −3

Original line number	Diff line number	Diff line
		@@ -37,7 +37,6 @@
		#define IB_USER_VERBS_H

		#include <linux/types.h>
		#include <rdma/ib_verbs.h>

		/*
		* Increment this value if any changes that break userspace ABI
		@@ -548,11 +547,17 @@ enum {
		};

		enum {
		IB_USER_LEGACY_LAST_QP_ATTR_MASK = IB_QP_DEST_QPN
		/*
		* This value is equal to IB_QP_DEST_QPN.
		*/
		IB_USER_LEGACY_LAST_QP_ATTR_MASK = 1ULL << 20,
		};

		enum {
		IB_USER_LAST_QP_ATTR_MASK = IB_QP_RATE_LIMIT
		/*
		* This value is equal to IB_QP_RATE_LIMIT.
		*/
		IB_USER_LAST_QP_ATTR_MASK = 1ULL << 25,
		};

		struct ib_uverbs_ex_create_qp {