Commit 61413c2f authored Oct 17, 2010 by Julia Lawall Committed by Sage Weil Oct 20, 2010

fs/ceph/xattr.c: Use kmemdup

Convert a sequence of kmalloc and memcpy to use kmemdup.

The semantic patch that performs this transformation is:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression a,flag,len;
expression arg,e1,e2;
statement S;
@@

  a =
-  \(kmalloc\|kzalloc\)(len,flag)
+  kmemdup(arg,len,flag)
  <... when != a
  if (a == NULL || ...) S
  ...>
- memcpy(a,arg,len+1);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Sage Weil <sage@newdream.net>

parent 85b5aaa6

fs/ceph/xattr.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -716,10 +716,9 @@ int ceph_setxattr(struct dentry dentry, const char name,

		/* preallocate memory for xattr name, value, index node */
		err = -ENOMEM;
		newname = kmalloc(name_len + 1, GFP_NOFS);
		newname = kmemdup(name, name_len + 1, GFP_NOFS);
		if (!newname)
		goto out;
		memcpy(newname, name, name_len + 1);

		if (val_len) {
		newval = kmalloc(val_len + 1, GFP_NOFS);