Commit 60e377b5 authored Aug 02, 2016 by Alexandre Bounine Committed by Linus Torvalds Aug 02, 2016

rapidio/idt_gen2: fix locking warning

Fix lockdep warning during device probing: move sysfs initialization out
of code protected by a spin lock.

Link: http://lkml.kernel.org/r/1469125134-16523-10-git-send-email-alexandre.bounine@idt.com


Signed-off-by: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com>
Cc: Barry Wood <barry.wood@idt.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 06e1b249

drivers/rapidio/switches/idt_gen2.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -436,10 +436,11 @@ static int idtg2_probe(struct rio_dev rdev, const struct rio_device_id id)
		RIO_STD_RTE_DEFAULT_PORT, IDT_NO_ROUTE);
		}

		spin_unlock(&rdev->rswitch->lock);

		/* Create device-specific sysfs attributes */
		idtg2_sysfs(rdev, true);

		spin_unlock(&rdev->rswitch->lock);
		return 0;
		}

		@@ -452,11 +453,9 @@ static void idtg2_remove(struct rio_dev *rdev)
		return;
		}
		rdev->rswitch->ops = NULL;

		spin_unlock(&rdev->rswitch->lock);
		/* Remove device-specific sysfs attributes */
		idtg2_sysfs(rdev, false);

		spin_unlock(&rdev->rswitch->lock);
		}

		static struct rio_device_id idtg2_id_table[] = {