Commit 60337981 authored Jan 15, 2015 by Gregory CLEMENT Committed by Tejun Heo Jan 19, 2015

ata: libahci: Clean-up the ahci_platform_en/disable_phys functions



The phy_ functions handle the NULL pointer case, so there is no need
to skip them if there is a NULL pointer. Moreover, after the error
label there is already no check on the pointer. This patch removes the
unnecessary tests and brings some consistency.

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 5bc27ef7

drivers/ata/libahci_platform.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -54,9 +54,6 @@ static int ahci_platform_enable_phys(struct ahci_host_priv *hpriv)
		int rc, i;

		for (i = 0; i < hpriv->nports; i++) {
		if (!hpriv->phys[i])
		continue;

		rc = phy_init(hpriv->phys[i]);
		if (rc)
		goto disable_phys;
		@@ -89,9 +86,6 @@ static void ahci_platform_disable_phys(struct ahci_host_priv *hpriv)
		int i;

		for (i = 0; i < hpriv->nports; i++) {
		if (!hpriv->phys[i])
		continue;

		phy_power_off(hpriv->phys[i]);
		phy_exit(hpriv->phys[i]);
		}