Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5edf5ee4 authored by Olaf Hering's avatar Olaf Hering Committed by Greg Kroah-Hartman
Browse files

tools: hv: fix checks for origin of netlink message in hv_vss_daemon 



Similar to what commit 95a69ada ("tools:
hv: Netlink source address validation allows DoS") does in
hv_kvp_daemon, improve checks for origin of netlink connector message.

Signed-off-by: default avatarOlaf Hering <olaf@aepfle.de>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eb8905b8

tools/hv/hv_vss_daemon.c

+7 −1
Original line number Diff line number Diff line
@@ -186,13 +186,19 @@ int main(void) 
		len = recvfrom(fd, vss_recv_buffer, sizeof(vss_recv_buffer), 0,

				addr_p, &addr_l);



		if (len < 0 || addr.nl_pid) {

		if (len < 0) {

			syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",

					addr.nl_pid, errno, strerror(errno));

			close(fd);

			return -1;

		}



		if (addr.nl_pid) {

			syslog(LOG_WARNING, "Received packet from untrusted pid:%u",

					addr.nl_pid);

			continue;

		}



		incoming_msg = (struct nlmsghdr *)vss_recv_buffer;



		if (incoming_msg->nlmsg_type != NLMSG_DONE)