Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ed12f12 authored by Ilya Shchepetkov's avatar Ilya Shchepetkov Committed by Linus Torvalds
Browse files

drivers/rtc/rtc-pcf2123.c: initialize dynamic sysfs attributes 



Dynamically allocated sysfs attributes must be initialized using
sysfs_attr_init(), otherwise lockdep complains: BUG: key <address> not in
.data!

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarIlya Shchepetkov <shchepetkov@ispras.ru>
Cc: Chris Verges <chrisv@cyberswitching.com>
Cc: Christian Pellegrin <chripell@fsfe.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c81758fb

drivers/rtc/rtc-pcf2123.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -43,6 +43,7 @@ 
#include <linux/rtc.h>

#include <linux/rtc.h>

#include <linux/spi/spi.h>

#include <linux/spi/spi.h>

#include <linux/module.h>

#include <linux/module.h>

#include <linux/sysfs.h>





#define DRV_VERSION "0.6"

#define DRV_VERSION "0.6"
@@ -292,6 +293,7 @@ static int __devinit pcf2123_probe(struct spi_device *spi) 
	pdata->rtc = rtc;

	pdata->rtc = rtc;





	for (i = 0; i < 16; i++) {

	for (i = 0; i < 16; i++) {

		sysfs_attr_init(&pdata->regs[i].attr.attr);

		sprintf(pdata->regs[i].name, "%1x", i);

		sprintf(pdata->regs[i].name, "%1x", i);

		pdata->regs[i].attr.attr.mode = S_IRUGO | S_IWUSR;

		pdata->regs[i].attr.attr.mode = S_IRUGO | S_IWUSR;

		pdata->regs[i].attr.attr.name = pdata->regs[i].name;

		pdata->regs[i].attr.attr.name = pdata->regs[i].name;