Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e841efe authored by Dan Carpenter's avatar Dan Carpenter Committed by Felipe Balbi
Browse files

usb: gadget: udc: clean up a printk 



We already know what "value" is, so there is no need to check.  It
puzzles static checkers to have the unneeded condition.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 135b3c43

drivers/usb/gadget/udc/bdc/bdc_ep.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -881,8 +881,8 @@ static int ep_set_halt(struct bdc_ep *ep, u32 value) 




		ret = bdc_ep_set_stall(bdc, ep->ep_num);

		ret = bdc_ep_set_stall(bdc, ep->ep_num);

		if (ret)

		if (ret)

			dev_err(bdc->dev, "failed to %s STALL on %s\n",

			dev_err(bdc->dev, "failed to set STALL on %s\n",

				value ? "set" : "clear", ep->name);

				ep->name);

		else

		else

			ep->flags |= BDC_EP_STALL;

			ep->flags |= BDC_EP_STALL;

	} else {

	} else {
@@ -890,8 +890,8 @@ static int ep_set_halt(struct bdc_ep *ep, u32 value) 
		dev_dbg(bdc->dev, "Before Clear\n");

		dev_dbg(bdc->dev, "Before Clear\n");

		ret = bdc_ep_clear_stall(bdc, ep->ep_num);

		ret = bdc_ep_clear_stall(bdc, ep->ep_num);

		if (ret)

		if (ret)

			dev_err(bdc->dev, "failed to %s STALL on %s\n",

			dev_err(bdc->dev, "failed to clear STALL on %s\n",

				value ? "set" : "clear", ep->name);

				ep->name);

		else

		else

			ep->flags &= ~BDC_EP_STALL;

			ep->flags &= ~BDC_EP_STALL;

		dev_dbg(bdc->dev, "After  Clear\n");

		dev_dbg(bdc->dev, "After  Clear\n");