Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e030d5c authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman
Browse files

Drivers: hv: vmbus: Don't leak memory when a channel is rescinded 



When we close a channel that has been rescinded, we will leak memory since
vmbus_teardown_gpadl() returns an error. Fix this so that we can properly
cleanup the memory allocated to the ring buffers.

Fixes: ccb61f8a ("Drivers: hv: vmbus: Fix a rescind handling bug")

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9a547602

drivers/hv/channel.c

+8 −5
Original line number Diff line number Diff line
@@ -502,12 +502,15 @@ int vmbus_teardown_gpadl(struct vmbus_channel *channel, u32 gpadl_handle) 


	wait_for_completion(&info->waitevent);



	if (channel->rescind) {

		ret = -ENODEV;

		goto post_msg_err;

	}



post_msg_err:

	/*

	 * If the channel has been rescinded;

	 * we will be awakened by the rescind

	 * handler; set the error code to zero so we don't leak memory.

	 */

	if (channel->rescind)

		ret = 0;



	spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);

	list_del(&info->msglistentry);

	spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);