Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d7ebb9c authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] FlashPoint: fix off by one tests 



The check on MAX_SCSI_TAR should be >= instead of > or we could go past the
end of the array.

Joe Eykholt aslo correctly points out that the check on MAX_LUN should be
>= as well.  That matches with how it is used in the rest of the file.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 0ed8570e

drivers/scsi/FlashPoint.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -3924,7 +3924,7 @@ static void FPT_sinits(struct sccb *p_sccb, unsigned char p_card) 
{

{

	struct sccb_mgr_tar_info *currTar_Info;

	struct sccb_mgr_tar_info *currTar_Info;





	if ((p_sccb->TargID > MAX_SCSI_TAR) || (p_sccb->Lun > MAX_LUN)) {

	if ((p_sccb->TargID >= MAX_SCSI_TAR) || (p_sccb->Lun >= MAX_LUN)) {

		return;

		return;

	}

	}

	currTar_Info = &FPT_sccbMgrTbl[p_card][p_sccb->TargID];

	currTar_Info = &FPT_sccbMgrTbl[p_card][p_sccb->TargID];