Commit 5d74aa7f authored Oct 03, 2017 by Anup Patel Committed by Vinod Koul Oct 23, 2017

dmaengine: bcm-sba-raid: serialize dma_cookie_complete() using reqs_lock



As-per documentation in driver/dma/dmaengine.h, the
dma_cookie_complete() API should be called with lock
held.

This patch ensures that Broadcom SBA RAID driver calls
the dma_cookie_complete() API with reqs_lock held.

Signed-off-by: Anup Patel <anup.patel@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 2bd6bf03

drivers/dma/bcm-sba-raid.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -442,7 +442,9 @@ static void sba_process_received_request(struct sba_device *sba,

		WARN_ON(tx->cookie < 0);
		if (tx->cookie > 0) {
		spin_lock_irqsave(&sba->reqs_lock, flags);
		dma_cookie_complete(tx);
		spin_unlock_irqrestore(&sba->reqs_lock, flags);
		dmaengine_desc_get_callback_invoke(tx, NULL);
		dma_descriptor_unmap(tx);
		tx->callback = NULL;