Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5bf1e1ee authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe
Browse files

lightnvm: potential underflow in pblk_read_rq() 



This is a static checker fix, and perhaps not a real bug.  The static
checker thinks that nr_secs could be negative.  It would result in
zeroing more memory than intended.  Anyway, even if it's not a bug,
changing this variable to unsigned makes the code easier to audit.

Fixes: a4bd217b ("lightnvm: physical block device (pblk) target")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJavier González <javier@cnexlabs.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 19b7ccf8

drivers/lightnvm/pblk-read.c

+1 −1
Original line number Diff line number Diff line
@@ -288,7 +288,7 @@ static void pblk_read_rq(struct pblk *pblk, struct nvm_rq *rqd, 
int pblk_submit_read(struct pblk *pblk, struct bio *bio)

{

	struct nvm_tgt_dev *dev = pblk->dev;

	int nr_secs = pblk_get_secs(bio);

	unsigned int nr_secs = pblk_get_secs(bio);

	struct nvm_rq *rqd;

	unsigned long read_bitmap; /* Max 64 ppas per request */

	unsigned int bio_init_idx;