Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5be6fdc0 authored by Gerald Schaefer's avatar Gerald Schaefer Committed by Martin Schwidefsky
Browse files

dcssblk: issue warning when trying to save SN/EN type DCSS 



The content of a DCSS of type SN or EN cannot be saved. Issue a warning when
trying to save such a DCSS. Depending on the setup, this may be a user error
or intended behaviour e.g. with a multi-DCSS device.

Signed-off-by: default avatarGerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 10ad34bc

drivers/s390/block/dcssblk.c

+13 −2
Original line number Diff line number Diff line
@@ -438,6 +438,12 @@ dcssblk_save_store(struct device *dev, struct device_attribute *attr, const char 
			pr_info("All DCSSs that map to device %s are "

				"saved\n", dev_info->segment_name);

			list_for_each_entry(entry, &dev_info->seg_list, lh) {

				if (entry->segment_type == SEG_TYPE_EN ||

				    entry->segment_type == SEG_TYPE_SN)

					pr_warn("DCSS %s is of type SN or EN"

						" and cannot be saved\n",

						entry->segment_name);

				else

					segment_save(entry->segment_name);

			}

		}  else {
@@ -797,6 +803,11 @@ dcssblk_release(struct gendisk *disk, fmode_t mode) 
		pr_info("Device %s has become idle and is being saved "

			"now\n", dev_info->segment_name);

		list_for_each_entry(entry, &dev_info->seg_list, lh) {

			if (entry->segment_type == SEG_TYPE_EN ||

			    entry->segment_type == SEG_TYPE_SN)

				pr_warn("DCSS %s is of type SN or EN and cannot"

					" be saved\n", entry->segment_name);

			else

				segment_save(entry->segment_name);

		}

		dev_info->save_pending = 0;