Commit 5b40dc78 authored Mar 16, 2006 by Christoph Lameter Committed by Linus Torvalds Mar 17, 2006

[PATCH] fix race in pagevec_strip?



We can call try_to_release_page() with PagePrivate off and a valid
page->mapping This may cause all sorts of trouble for the filesystem
*_releasepage() handlers.  XFS bombs out in that case.

Lock the page before checking for page private.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 8ba32fde

mm/swap.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -393,6 +393,7 @@ void pagevec_strip(struct pagevec *pvec)
		struct page *page = pvec->pages[i];

		if (PagePrivate(page) && !TestSetPageLocked(page)) {
		if (PagePrivate(page))
		try_to_release_page(page, 0);
		unlock_page(page);
		}