Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5abc7dd7 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Rob Clark
Browse files

drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference 



_minor_ is being dereferenced before it is null checked, hence there
is a potential null pointer dereference. Fix this by moving the pointer
dereference after _minor_ has been null checked.

Fixes: 024ad8df763f ("drm/msm: add a5xx specific debugfs")
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent fb48989e

drivers/gpu/drm/msm/adreno/a5xx_debugfs.c

+3 −1
Original line number Diff line number Diff line
@@ -159,13 +159,15 @@ DEFINE_SIMPLE_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n"); 


int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)

{

	struct drm_device *dev = minor->dev;

	struct drm_device *dev;

	struct dentry *ent;

	int ret;



	if (!minor)

		return 0;



	dev = minor->dev;



	ret = drm_debugfs_create_files(a5xx_debugfs_list,

			ARRAY_SIZE(a5xx_debugfs_list),

			minor->debugfs_root, minor);