Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a1e5953 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Keith Busch
Browse files

nvme-fabrics: don't check for non-NULL module in nvmf_register_transport 



THIS_MODULE evaluates to NULL when used from code built into the kernel,
thus breaking built-in transport modules.  Remove the bogus check.

Fixes: 0de5cd36 ("nvme-fabrics: protect against module unload during create_ctrl")
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
parent af27d940

drivers/nvme/host/fabrics.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -493,7 +493,7 @@ EXPORT_SYMBOL_GPL(nvmf_should_reconnect); 
 */

 */

int nvmf_register_transport(struct nvmf_transport_ops *ops)

int nvmf_register_transport(struct nvmf_transport_ops *ops)

{

{

	if (!ops->create_ctrl || !ops->module)

	if (!ops->create_ctrl)

		return -EINVAL;

		return -EINVAL;





	down_write(&nvmf_transports_rwsem);

	down_write(&nvmf_transports_rwsem);