Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5958fde7 authored by Anton Vasilyev's avatar Anton Vasilyev Committed by Bartlomiej Zolnierkiewicz
Browse files

video: goldfishfb: fix memory leak on driver remove 



goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does
not have deallocation of fb, which leads to memory leak on probe/remove.

The patch adds deallocation into goldfish_fb_remove().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent e32e2fe6

drivers/video/fbdev/goldfishfb.c

+1 −0
Original line number Diff line number Diff line
@@ -304,6 +304,7 @@ static int goldfish_fb_remove(struct platform_device *pdev) 
	dma_free_coherent(&pdev->dev, framesize, (void *)fb->fb.screen_base,

						fb->fb.fix.smem_start);

	iounmap(fb->reg_base);

	kfree(fb);

	return 0;

}