Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 587cc286 authored by Eliad Peller's avatar Eliad Peller Committed by Luciano Coelho
Browse files

wlcore: compare ssid_len before comparing ssids 



When comparing 2 ssids the ssid_len must be taken
into account. Otherwise, a substring will be treated
as equal.

This bug might cause ssids to get scanned as
public ssids (rather than hidden), resulting in
broadcast probe request (instead of ssid-specific
ones)

Signed-off-by: default avatarEliad Peller <eliad@wizery.com>
Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
parent 78f85f50

drivers/net/wireless/ti/wlcore/scan.c

+3 −1
Original line number Diff line number Diff line
@@ -605,7 +605,9 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl, 
					continue;



				for (j = 0; j < cmd->n_ssids; j++)

					if (!memcmp(req->ssids[i].ssid,

					if ((req->ssids[i].ssid_len ==

					     req->ssids[j].ssid_len) &&

					    !memcmp(req->ssids[i].ssid,

						   cmd->ssids[j].ssid,

						   req->ssids[i].ssid_len)) {

						cmd->ssids[j].type =