Commit 583bea6c authored Oct 08, 2014 by Tapasweni Pathak Committed by Greg Kroah-Hartman Oct 20, 2014

staging: comedi: use DIV_ROUND_UP



The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.

Coccinelle script used :

// <smpl>
@haskernel@
@@
@depends on haskernel@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 146ea835

drivers/staging/comedi/drivers.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -317,8 +317,7 @@ unsigned int comedi_bytes_per_scan(struct comedi_subdevice *s)
		case COMEDI_SUBD_DO:
		case COMEDI_SUBD_DIO:
		bits_per_sample = 8 * bytes_per_sample(s);
		num_samples = (cmd->chanlist_len + bits_per_sample - 1) /
		bits_per_sample;
		num_samples = DIV_ROUND_UP(cmd->chanlist_len, bits_per_sample);
		break;
		default:
		num_samples = cmd->chanlist_len;