Commit 56d95f31 authored May 10, 2012 by Greg Kroah-Hartman

USB: gadget: ci13xx_pci: remove unneeded check in ci13xxx_pci_probe()



As pointed out by Dan Carpenter, the check for NULL for the id variable
is no longer needed, especially as we just dereferenced it a few lines
earlier, causing an oops if it really was NULL.

This was caused by 62bb84ed: "usb: gadget: ci13xxx: convert to
platform device".

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f639554b

drivers/usb/gadget/ci13xxx_pci.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -51,9 +51,6 @@ static int __devinit ci13xxx_pci_probe(struct pci_dev *pdev,
	struct resource res[3];		struct resource res[3];
	int retval = 0, nres = 2;		int retval = 0, nres = 2;

	if (id == NULL)
	return -EINVAL;

	retval = pci_enable_device(pdev);		retval = pci_enable_device(pdev);
	if (retval)		if (retval)
	goto done;		goto done;