Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5660ce34 authored by Julia Lawall's avatar Julia Lawall Committed by Ingo Molnar
Browse files

perf tools: Correct size given to memset 

Memset should be given the size of the structure, not the size
of the pointer.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
type T;
T *x;
expression E;
@@

memset(x, E, sizeof(
+ *
 x))
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <Pine.LNX.4.64.0912092026000.1870@ask.diku.dk>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 21140f4d

tools/perf/util/probe-event.c

+1 −1
Original line number Diff line number Diff line
@@ -376,7 +376,7 @@ static void clear_probe_point(struct probe_point *pp) 
		free(pp->args);

	for (i = 0; i < pp->found; i++)

		free(pp->probes[i]);

	memset(pp, 0, sizeof(pp));

	memset(pp, 0, sizeof(*pp));

}



/* Show an event */

tools/perf/util/trace-event-parse.c

+1 −1
Original line number Diff line number Diff line
@@ -1477,7 +1477,7 @@ process_fields(struct event *event, struct print_flag_sym **list, char **tok) 
			goto out_free;



		field = malloc_or_die(sizeof(*field));

		memset(field, 0, sizeof(field));

		memset(field, 0, sizeof(*field));



		value = arg_eval(arg);

		field->value = strdup(value);