Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5523d11c authored by Luciano Coelho's avatar Luciano Coelho Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: always use mac color zero 



We don't really need to use different mac colors when adding mac
contexts, because they're not used anywhere.  In fact, the firmware
doesn't accept 255 as a valid color, so we get into a SYSASSERT 0x3401
when we reach that.

Remove the color increment to use always zero and avoid reaching 255.

CC: <stable@vger.kernel.org> [3.10+]
Signed-off-by: default avatarLuciano Coelho <luciano.coelho@intel.com>
Reviewed-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent edbad051

drivers/net/wireless/iwlwifi/mvm/mac80211.c

+0 −3
Original line number Diff line number Diff line
@@ -707,9 +707,6 @@ static void iwl_mvm_cleanup_iterator(void *data, u8 *mac, 
	mvmvif->uploaded = false;

	mvmvif->ap_sta_id = IWL_MVM_STATION_COUNT;



	/* does this make sense at all? */

	mvmvif->color++;



	spin_lock_bh(&mvm->time_event_lock);

	iwl_mvm_te_clear_data(mvm, &mvmvif->time_event_data);

	spin_unlock_bh(&mvm->time_event_lock);