Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5349a0f7 authored by Vidyullatha Kanchanapally's avatar Vidyullatha Kanchanapally Committed by Johannes Berg
Browse files

cfg80211: Use a structure to pass connect response params 



Currently the connect event from driver takes all the connection
response parameters as arguments. With support for new features these
response parameters can grow. Use a structure to pass these parameters
rather than passing them as function arguments.

Signed-off-by: default avatarVidyullatha Kanchanapally <vkanchan@qti.qualcomm.com>
Signed-off-by: default avatarJouni Malinen <jouni@qca.qualcomm.com>
[add to documentation]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 667a2e6b

Documentation/driver-api/80211/cfg80211.rst

+6 −0
Original line number Diff line number Diff line
@@ -179,6 +179,12 @@ Actions and configuration 
.. kernel-doc:: include/net/cfg80211.h

   :functions: cfg80211_ibss_joined



.. kernel-doc:: include/net/cfg80211.h

   :functions: cfg80211_connect_resp_params



.. kernel-doc:: include/net/cfg80211.h

   :functions: cfg80211_connect_done



.. kernel-doc:: include/net/cfg80211.h

   :functions: cfg80211_connect_result

include/net/cfg80211.h

+83 −8
Original line number Diff line number Diff line
@@ -5135,6 +5135,60 @@ static inline void cfg80211_testmode_event(struct sk_buff *skb, gfp_t gfp) 
#define CFG80211_TESTMODE_DUMP(cmd)

#endif



/**

 * struct cfg80211_connect_resp_params - Connection response params

 * @status: Status code, %WLAN_STATUS_SUCCESS for successful connection, use

 *	%WLAN_STATUS_UNSPECIFIED_FAILURE if your device cannot give you

 *	the real status code for failures. If this call is used to report a

 *	failure due to a timeout (e.g., not receiving an Authentication frame

 *	from the AP) instead of an explicit rejection by the AP, -1 is used to

 *	indicate that this is a failure, but without a status code.

 *	@timeout_reason is used to report the reason for the timeout in that

 *	case.

 * @bssid: The BSSID of the AP (may be %NULL)

 * @bss: Entry of bss to which STA got connected to, can be obtained through

 *	cfg80211_get_bss() (may be %NULL). Only one parameter among @bssid and

 *	@bss needs to be specified.

 * @req_ie: Association request IEs (may be %NULL)

 * @req_ie_len: Association request IEs length

 * @resp_ie: Association response IEs (may be %NULL)

 * @resp_ie_len: Association response IEs length

 * @timeout_reason: Reason for connection timeout. This is used when the

 *	connection fails due to a timeout instead of an explicit rejection from

 *	the AP. %NL80211_TIMEOUT_UNSPECIFIED is used when the timeout reason is

 *	not known. This value is used only if @status < 0 to indicate that the

 *	failure is due to a timeout and not due to explicit rejection by the AP.

 *	This value is ignored in other cases (@status >= 0).

 */

struct cfg80211_connect_resp_params {

	int status;

	const u8 *bssid;

	struct cfg80211_bss *bss;

	const u8 *req_ie;

	size_t req_ie_len;

	const u8 *resp_ie;

	size_t resp_ie_len;

	enum nl80211_timeout_reason timeout_reason;

};



/**

 * cfg80211_connect_done - notify cfg80211 of connection result

 *

 * @dev: network device

 * @params: connection response parameters

 * @gfp: allocation flags

 *

 * It should be called by the underlying driver once execution of the connection

 * request from connect() has been completed. This is similar to

 * cfg80211_connect_bss(), but takes a structure pointer for connection response

 * parameters. Only one of the functions among cfg80211_connect_bss(),

 * cfg80211_connect_result(), cfg80211_connect_timeout(),

 * and cfg80211_connect_done() should be called.

 */

void cfg80211_connect_done(struct net_device *dev,

			   struct cfg80211_connect_resp_params *params,

			   gfp_t gfp);



/**

 * cfg80211_connect_bss - notify cfg80211 of connection result

 *
@@ -5165,13 +5219,31 @@ static inline void cfg80211_testmode_event(struct sk_buff *skb, gfp_t gfp) 
 * It should be called by the underlying driver once execution of the connection

 * request from connect() has been completed. This is similar to

 * cfg80211_connect_result(), but with the option of identifying the exact bss

 * entry for the connection. Only one of these functions should be called.

 * entry for the connection. Only one of the functions among

 * cfg80211_connect_bss(), cfg80211_connect_result(),

 * cfg80211_connect_timeout(), and cfg80211_connect_done() should be called.

 */

void cfg80211_connect_bss(struct net_device *dev, const u8 *bssid,

static inline void

cfg80211_connect_bss(struct net_device *dev, const u8 *bssid,

		     struct cfg80211_bss *bss, const u8 *req_ie,

		     size_t req_ie_len, const u8 *resp_ie,

		     size_t resp_ie_len, int status, gfp_t gfp,

			  enum nl80211_timeout_reason timeout_reason);

		     enum nl80211_timeout_reason timeout_reason)

{

	struct cfg80211_connect_resp_params params;



	memset(&params, 0, sizeof(params));

	params.status = status;

	params.bssid = bssid;

	params.bss = bss;

	params.req_ie = req_ie;

	params.req_ie_len = req_ie_len;

	params.resp_ie = resp_ie;

	params.resp_ie_len = resp_ie_len;

	params.timeout_reason = timeout_reason;



	cfg80211_connect_done(dev, &params, gfp);

}



/**

 * cfg80211_connect_result - notify cfg80211 of connection result
@@ -5190,7 +5262,8 @@ void cfg80211_connect_bss(struct net_device *dev, const u8 *bssid, 
 * It should be called by the underlying driver once execution of the connection

 * request from connect() has been completed. This is similar to

 * cfg80211_connect_bss() which allows the exact bss entry to be specified. Only

 * one of these functions should be called.

 * one of the functions among cfg80211_connect_bss(), cfg80211_connect_result(),

 * cfg80211_connect_timeout(), and cfg80211_connect_done() should be called.

 */

static inline void

cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
@@ -5217,7 +5290,9 @@ cfg80211_connect_result(struct net_device *dev, const u8 *bssid, 
 * in a sequence where no explicit authentication/association rejection was

 * received from the AP. This could happen, e.g., due to not being able to send

 * out the Authentication or Association Request frame or timing out while

 * waiting for the response.

 * waiting for the response. Only one of the functions among

 * cfg80211_connect_bss(), cfg80211_connect_result(),

 * cfg80211_connect_timeout(), and cfg80211_connect_done() should be called.

 */

static inline void

cfg80211_connect_timeout(struct net_device *dev, const u8 *bssid,

net/wireless/core.h

+4 −16
Original line number Diff line number Diff line
@@ -226,16 +226,7 @@ struct cfg80211_event { 
	enum cfg80211_event_type type;



	union {

		struct {

			u8 bssid[ETH_ALEN];

			const u8 *req_ie;

			const u8 *resp_ie;

			size_t req_ie_len;

			size_t resp_ie_len;

			struct cfg80211_bss *bss;

			int status; /* -1 = failed; 0..65535 = status code */

			enum nl80211_timeout_reason timeout_reason;

		} cr;

		struct cfg80211_connect_resp_params cr;

		struct {

			const u8 *req_ie;

			const u8 *resp_ie;
@@ -398,12 +389,9 @@ int cfg80211_connect(struct cfg80211_registered_device *rdev, 
		     struct cfg80211_connect_params *connect,

		     struct cfg80211_cached_keys *connkeys,

		     const u8 *prev_bssid);

void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid,

			       const u8 *req_ie, size_t req_ie_len,

			       const u8 *resp_ie, size_t resp_ie_len,

			       int status, bool wextev,

			       struct cfg80211_bss *bss,

			       enum nl80211_timeout_reason timeout_reason);

void __cfg80211_connect_result(struct net_device *dev,

			       struct cfg80211_connect_resp_params *params,

			       bool wextev);

void __cfg80211_disconnected(struct net_device *dev, const u8 *ie,

			     size_t ie_len, u16 reason, bool from_ap);

int cfg80211_disconnect(struct cfg80211_registered_device *rdev,

net/wireless/mlme.c

+12 −8
Original line number Diff line number Diff line
@@ -26,9 +26,16 @@ void cfg80211_rx_assoc_resp(struct net_device *dev, struct cfg80211_bss *bss, 
	struct wiphy *wiphy = wdev->wiphy;

	struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy);

	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)buf;

	u8 *ie = mgmt->u.assoc_resp.variable;

	int ieoffs = offsetof(struct ieee80211_mgmt, u.assoc_resp.variable);

	u16 status_code = le16_to_cpu(mgmt->u.assoc_resp.status_code);

	struct cfg80211_connect_resp_params cr;



	memset(&cr, 0, sizeof(cr));

	cr.status = (int)le16_to_cpu(mgmt->u.assoc_resp.status_code);

	cr.bssid = mgmt->bssid;

	cr.bss = bss;

	cr.resp_ie = mgmt->u.assoc_resp.variable;

	cr.resp_ie_len =

		len - offsetof(struct ieee80211_mgmt, u.assoc_resp.variable);

	cr.timeout_reason = NL80211_TIMEOUT_UNSPECIFIED;



	trace_cfg80211_send_rx_assoc(dev, bss);
@@ -38,7 +45,7 @@ void cfg80211_rx_assoc_resp(struct net_device *dev, struct cfg80211_bss *bss, 
	 * and got a reject -- we only try again with an assoc

	 * frame instead of reassoc.

	 */

	if (cfg80211_sme_rx_assoc_resp(wdev, status_code)) {

	if (cfg80211_sme_rx_assoc_resp(wdev, cr.status)) {

		cfg80211_unhold_bss(bss_from_pub(bss));

		cfg80211_put_bss(wiphy, bss);

		return;
@@ -46,10 +53,7 @@ void cfg80211_rx_assoc_resp(struct net_device *dev, struct cfg80211_bss *bss, 


	nl80211_send_rx_assoc(rdev, dev, buf, len, GFP_KERNEL, uapsd_queues);

	/* update current_bss etc., consumes the bss reference */

	__cfg80211_connect_result(dev, mgmt->bssid, NULL, 0, ie, len - ieoffs,

				  status_code,

				  status_code == WLAN_STATUS_SUCCESS, bss,

				  NL80211_TIMEOUT_UNSPECIFIED);

	__cfg80211_connect_result(dev, &cr, cr.status == WLAN_STATUS_SUCCESS);

}

EXPORT_SYMBOL(cfg80211_rx_assoc_resp);

net/wireless/nl80211.c

+15 −15
Original line number Diff line number Diff line
@@ -13464,17 +13464,14 @@ void nl80211_send_assoc_timeout(struct cfg80211_registered_device *rdev, 
}



void nl80211_send_connect_result(struct cfg80211_registered_device *rdev,

				 struct net_device *netdev, const u8 *bssid,

				 const u8 *req_ie, size_t req_ie_len,

				 const u8 *resp_ie, size_t resp_ie_len,

				 int status,

				 enum nl80211_timeout_reason timeout_reason,

				 struct net_device *netdev,

				 struct cfg80211_connect_resp_params *cr,

				 gfp_t gfp)

{

	struct sk_buff *msg;

	void *hdr;



	msg = nlmsg_new(100 + req_ie_len + resp_ie_len, gfp);

	msg = nlmsg_new(100 + cr->req_ie_len + cr->resp_ie_len, gfp);

	if (!msg)

		return;
@@ -13486,17 +13483,20 @@ void nl80211_send_connect_result(struct cfg80211_registered_device *rdev, 


	if (nla_put_u32(msg, NL80211_ATTR_WIPHY, rdev->wiphy_idx) ||

	    nla_put_u32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex) ||

	    (bssid && nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid)) ||

	    (cr->bssid &&

	     nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, cr->bssid)) ||

	    nla_put_u16(msg, NL80211_ATTR_STATUS_CODE,

			status < 0 ? WLAN_STATUS_UNSPECIFIED_FAILURE :

			status) ||

	    (status < 0 &&

			cr->status < 0 ? WLAN_STATUS_UNSPECIFIED_FAILURE :

			cr->status) ||

	    (cr->status < 0 &&

	     (nla_put_flag(msg, NL80211_ATTR_TIMED_OUT) ||

	      nla_put_u32(msg, NL80211_ATTR_TIMEOUT_REASON, timeout_reason))) ||

	    (req_ie &&

	     nla_put(msg, NL80211_ATTR_REQ_IE, req_ie_len, req_ie)) ||

	    (resp_ie &&

	     nla_put(msg, NL80211_ATTR_RESP_IE, resp_ie_len, resp_ie)))

	      nla_put_u32(msg, NL80211_ATTR_TIMEOUT_REASON,

			  cr->timeout_reason))) ||

	    (cr->req_ie &&

	     nla_put(msg, NL80211_ATTR_REQ_IE, cr->req_ie_len, cr->req_ie)) ||

	    (cr->resp_ie &&

	     nla_put(msg, NL80211_ATTR_RESP_IE, cr->resp_ie_len,

		     cr->resp_ie)))

		goto nla_put_failure;



	genlmsg_end(msg, hdr);