Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 512ddf7d authored by Denis Efremov's avatar Denis Efremov Committed by Masahiro Yamada
Browse files

coccicheck: return proper error code on fail 



If coccicheck fails, it should return an error code distinct from zero
to signal about an internal problem. Current code instead of exiting with
the tool's error code returns the error code of 'echo "coccicheck failed"'
which is almost always equals to zero, thus failing the original intention
of alerting about a problem. This patch fixes the code.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarDenis Efremov <efremov@linux.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent 09d4d964

scripts/coccicheck

+3 −2
Original line number Diff line number Diff line
@@ -128,9 +128,10 @@ run_cmd_parmap() { 
	fi

	echo $@ >>$DEBUG_FILE

	$@ 2>>$DEBUG_FILE

	if [[ $? -ne 0 ]]; then

	err=$?

	if [[ $err -ne 0 ]]; then

		echo "coccicheck failed"

		exit $?

		exit $err

	fi

}