Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5124b592 authored by Wolfram Sang's avatar Wolfram Sang Committed by Ulf Hansson
Browse files

mmc: renesas_sdhi: use extra flag for CBSY usage 



There is one SDHI instance on Gen2 which does not have the CBSY bit.
So, turn CBSY usage into an extra flag and set it accordingly. This has
the additional advantage that we can also set it for other incarnations
later.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: default avatarChris Brandt <Chris.Brandt@renesas.com>
Reviewed-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent dde6256b

drivers/mmc/host/renesas_sdhi_core.c

+5 −1
Original line number Diff line number Diff line
@@ -429,7 +429,7 @@ static int renesas_sdhi_write16_hook(struct tmio_mmc_host *host, int addr) 
	case CTL_TRANSACTION_CTL:

	case CTL_DMA_ENABLE:

	case EXT_ACC:

		if (host->pdata->flags & TMIO_MMC_MIN_RCAR2)

		if (host->pdata->flags & TMIO_MMC_HAVE_CBSY)

			bit = TMIO_STAT_CMD_BUSY;

		/* fallthrough */

	case CTL_SD_CARD_CLK_CTL:
@@ -588,6 +588,10 @@ int renesas_sdhi_probe(struct platform_device *pdev, 
	if (ret < 0)

		goto efree;



	/* One Gen2 SDHI incarnation does NOT have a CBSY bit */

	if (sd_ctrl_read16(host, CTL_VERSION) == SDHI_VER_GEN2_SDR50)

		mmc_data->flags &= ~TMIO_MMC_HAVE_CBSY;



	/* Enable tuning iff we have an SCC and a supported mode */

	if (of_data && of_data->scc_offset &&

	    (host->mmc->caps & MMC_CAP_UHS_SDR104 ||

drivers/mmc/host/renesas_sdhi_internal_dmac.c

+2 −1
Original line number Diff line number Diff line
@@ -72,7 +72,8 @@ static struct renesas_sdhi_scc rcar_gen3_scc_taps[] = { 


static const struct renesas_sdhi_of_data of_rcar_gen3_compatible = {

	.tmio_flags	= TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE |

			  TMIO_MMC_CLK_ACTUAL | TMIO_MMC_MIN_RCAR2,

			  TMIO_MMC_CLK_ACTUAL | TMIO_MMC_HAVE_CBSY |

			  TMIO_MMC_MIN_RCAR2,

	.capabilities	= MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |

			  MMC_CAP_CMD23,

	.bus_shift	= 2,

drivers/mmc/host/renesas_sdhi_sys_dmac.c

+4 −2
Original line number Diff line number Diff line
@@ -58,7 +58,8 @@ static struct renesas_sdhi_scc rcar_gen2_scc_taps[] = { 


static const struct renesas_sdhi_of_data of_rcar_gen2_compatible = {

	.tmio_flags	= TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE |

			  TMIO_MMC_CLK_ACTUAL | TMIO_MMC_MIN_RCAR2,

			  TMIO_MMC_CLK_ACTUAL | TMIO_MMC_HAVE_CBSY |

			  TMIO_MMC_MIN_RCAR2,

	.capabilities	= MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |

			  MMC_CAP_CMD23,

	.dma_buswidth	= DMA_SLAVE_BUSWIDTH_4_BYTES,
@@ -78,7 +79,8 @@ static struct renesas_sdhi_scc rcar_gen3_scc_taps[] = { 


static const struct renesas_sdhi_of_data of_rcar_gen3_compatible = {

	.tmio_flags	= TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE |

			  TMIO_MMC_CLK_ACTUAL | TMIO_MMC_MIN_RCAR2,

			  TMIO_MMC_CLK_ACTUAL | TMIO_MMC_HAVE_CBSY |

			  TMIO_MMC_MIN_RCAR2,

	.capabilities	= MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |

			  MMC_CAP_CMD23,

	.bus_shift	= 2,

include/linux/mfd/tmio.h

+3 −0
Original line number Diff line number Diff line
@@ -107,6 +107,9 @@ 
 */

#define TMIO_MMC_CLK_ACTUAL		BIT(10)



/* Some controllers have a CBSY bit */

#define TMIO_MMC_HAVE_CBSY		BIT(11)



int tmio_core_mmc_enable(void __iomem *cnf, int shift, unsigned long base);

int tmio_core_mmc_resume(void __iomem *cnf, int shift, unsigned long base);

void tmio_core_mmc_pwr(void __iomem *cnf, int shift, int state);