Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50f72b57 authored by Jeff Dike's avatar Jeff Dike Committed by Linus Torvalds
Browse files

[PATCH] uml: fix x86_64 with !CONFIG_FRAME_POINTER 



UML/x86_64 doesn't run when built with frame pointers disabled.  There
was an implicit frame pointer assumption in the stub segfault handler.
With frame pointers disabled, UML dies on handling its first page fault.

The container-of part of this is from Paolo Giarrusso <blaisorblade@yahoo.it>.

Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 3dd08325

arch/um/sys-x86_64/stub_segv.c

+28 −9
Original line number Diff line number Diff line
@@ -10,6 +10,22 @@ 
#include "uml-config.h"

#include "sysdep/sigcontext.h"

#include "sysdep/faultinfo.h"

#include <stddef.h>



/* Copied from sys-x86_64/signal.c - Can't find an equivalent definition

 * in the libc headers anywhere.

 */

struct rt_sigframe

{

	char *pretcode;

	struct ucontext uc;

	struct siginfo info;

};



/* Copied here from <linux/kernel.h> - we're userspace. */

#define container_of(ptr, type, member) ({                   \

	const typeof( ((type *)0)->member ) *__mptr = (ptr); \

	(type *)( (char *)__mptr - offsetof(type,member) );})



void __attribute__ ((__section__ (".__syscall_stub")))

stub_segv_handler(int sig)
@@ -22,11 +38,14 @@ stub_segv_handler(int sig) 


	__asm__("movq %0, %%rax ; syscall": : "g" (__NR_getpid));	

	__asm__("movq %%rax, %%rdi ; movq %0, %%rax ; movq %1, %%rsi ;"

		"syscall": : "g" (__NR_kill), "g" (SIGUSR1));

	/* Two popqs to restore the stack to the state just before entering

	 * the handler, one pops the return address, the other pops the frame

	 * pointer.

		"syscall": : "g" (__NR_kill), "g" (SIGUSR1) : 

		"%rdi", "%rax", "%rsi");

	/* sys_sigreturn expects that the stack pointer will be 8 bytes into

	 * the signal frame.  So, we use the ucontext pointer, which we know

	 * already, to get the signal frame pointer, and add 8 to that.

	 */

	__asm__("popq %%rax ; popq %%rax ; movq %0, %%rax ; syscall" : : "g"

		(__NR_rt_sigreturn));

	__asm__("movq %0, %%rsp": : 

		"g" ((unsigned long) container_of(uc, struct rt_sigframe, 

						  uc) + 8));

	__asm__("movq %0, %%rax ; syscall" : : "g" (__NR_rt_sigreturn));

}