Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 509859e4 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Greg Kroah-Hartman
Browse files

thermal: rcar_thermal: Prevent doing work after unbind 



[ Upstream commit 697ee786f15d7b65c7f3045d45fe3a05d28e0911 ]

When testing bind/unbind on r8a7791/koelsch:

    WARNING: CPU: 1 PID: 697 at lib/debugobjects.c:329 debug_print_object+0x8c/0xb4
    ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x10

This happens if the workqueue runs after the device has been unbound.
Fix this by cancelling any queued work during remove.

Fixes: e0a5172e ("thermal: rcar: add interrupt support")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aa3bbb8d

drivers/thermal/rcar_thermal.c

+1 −0
Original line number Diff line number Diff line
@@ -453,6 +453,7 @@ static int rcar_thermal_remove(struct platform_device *pdev) 


	rcar_thermal_for_each_priv(priv, common) {

		rcar_thermal_irq_disable(priv);

		cancel_delayed_work_sync(&priv->work);

		if (priv->chip->use_of_thermal)

			thermal_remove_hwmon_sysfs(priv->zone);

		else