Commit 4fe683f5 authored Jul 05, 2006 by Thomas Graf Committed by David S. Miller Jul 05, 2006

[PKT_SCHED]: Fix error handling while dumping actions



"return -err" and blindly inheriting the error code in the netlink
failure exception handler causes errors codes to be returned as
positive value therefore making them being ignored by the caller.

May lead to sending out incomplete netlink messages.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d152b4e1

net/sched/act_api.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -250,15 +250,17 @@ tcf_action_dump(struct sk_buff skb, struct tc_action act, int bind, int ref)
		RTA_PUT(skb, a->order, 0, NULL);
		err = tcf_action_dump_1(skb, a, bind, ref);
		if (err < 0)
		goto rtattr_failure;
		goto errout;
		r->rta_len = skb->tail - (u8*)r;
		}

		return 0;

		rtattr_failure:
		err = -EINVAL;
		errout:
		skb_trim(skb, b - skb->data);
		return -err;
		return err;
		}

		struct tc_action tcf_action_init_1(struct rtattr rta, struct rtattr *est,