Commit 4f97adff authored Jan 21, 2018 by Talat Batheesh Committed by Greg Kroah-Hartman Jan 31, 2018

net/mlx5e: Fix fixpoint divide exception in mlx5e_am_stats_compare




[ Upstream commit e58edaa4 ]

Helmut reported a bug about division by zero while
running traffic and doing physical cable pull test.

When the cable unplugged the ppms become zero, so when
dividing the current ppms by the previous ppms in the
next dim iteration there is division by zero.

This patch prevent this division for both ppms and epms.

Fixes: c3164d2f ("net/mlx5e: Added BW check for DIM decision mechanism")
Reported-by: Helmut Grauer <helmut.grauer@de.ibm.com>
Signed-off-by: Talat Batheesh <talatb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3eae0ba8

drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -197,9 +197,15 @@ static int mlx5e_am_stats_compare(struct mlx5e_rx_am_stats *curr,
		return (curr->bpms > prev->bpms) ? MLX5E_AM_STATS_BETTER :
		MLX5E_AM_STATS_WORSE;

		if (!prev->ppms)
		return curr->ppms ? MLX5E_AM_STATS_BETTER :
		MLX5E_AM_STATS_SAME;

		if (IS_SIGNIFICANT_DIFF(curr->ppms, prev->ppms))
		return (curr->ppms > prev->ppms) ? MLX5E_AM_STATS_BETTER :
		MLX5E_AM_STATS_WORSE;
		if (!prev->epms)
		return MLX5E_AM_STATS_SAME;

		if (IS_SIGNIFICANT_DIFF(curr->epms, prev->epms))
		return (curr->epms < prev->epms) ? MLX5E_AM_STATS_BETTER :