Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4defb5f9 authored by Colin Ian King's avatar Colin Ian King Committed by Mike Marshall
Browse files

orangefs: fix memory leak of string 'new' on exit path 



allocates string 'new' is not free'd on the exit path when
cdm_element_count <= 0. Fix this by kfree'ing it.

Fixes CoverityScan CID#1375923 "Resource Leak"

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent 19ff7fcc

fs/orangefs/orangefs-debugfs.c

+3 −1
Original line number Diff line number Diff line
@@ -671,8 +671,10 @@ int orangefs_prepare_debugfs_help_string(int at_boot) 
		 */

		cdm_element_count =

			orangefs_prepare_cdm_array(client_debug_array_string);

		if (cdm_element_count <= 0)

		if (cdm_element_count <= 0) {

			kfree(new);

			goto out;

		}



		for (i = 0; i < cdm_element_count; i++) {

			strlcat(new, "\t", string_size);