Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dbd8f63 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: gpio-regulator: Set the smallest voltage/current in the specified range 



Do not assume the gpio regulator states map is sorted in any order.
This patch ensures we always set the smallest voltage/current that falls within
the specified range.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 9d442061

drivers/regulator/gpio-regulator.c

+4 −4
Original line number Diff line number Diff line
@@ -105,15 +105,15 @@ static int gpio_regulator_set_value(struct regulator_dev *dev, 
					int min, int max)

{

	struct gpio_regulator_data *data = rdev_get_drvdata(dev);

	int ptr, target, state;

	int ptr, target, state, best_val = INT_MAX;



	target = -1;

	for (ptr = 0; ptr < data->nr_states; ptr++)

		if (data->states[ptr].value >= min &&

		if (data->states[ptr].value < best_val &&

		    data->states[ptr].value >= min &&

		    data->states[ptr].value <= max)

			target = data->states[ptr].gpios;



	if (target < 0)

	if (best_val == INT_MAX)

		return -EINVAL;



	for (ptr = 0; ptr < data->nr_gpios; ptr++) {