Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4be83e5a authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy_config 



rtl8169_init_phy() resets the PHY anyway after applying the chip-specific
PHY configuration. So we don't need to soft-reset the PHY as part of the
chip-specific configuration.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ccc007e4

drivers/net/ethernet/realtek/r8169.c

+0 −2
Original line number Diff line number Diff line
@@ -3800,8 +3800,6 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp) 
	rtl_writephy(tp, 0x1f, 0x0005);

	rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);

	rtl_writephy(tp, 0x1f, 0x0000);

	/* soft-reset phy */

	rtl_writephy(tp, MII_BMCR, BMCR_RESET | BMCR_ANENABLE | BMCR_ANRESTART);



	/* Broken BIOS workaround: feed GigaMAC registers with MAC address. */

	rtl_rar_exgmac_set(tp, tp->dev->dev_addr);