Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bc49274 authored by Anna-Maria Gleixner's avatar Anna-Maria Gleixner Committed by Will Deacon
Browse files

arm64: hw-breakpoint: Remove superfluous SMP function call 



Since commit 1cf4f629 ("cpu/hotplug: Move online calls to
hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call of
hw_breakpoint_reset(). To keep the calling convention, interrupts are
explicitly disabled around the call.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: default avatarAnna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 499c8150

arch/arm64/kernel/hw_breakpoint.c

+5 −3
Original line number Diff line number Diff line
@@ -886,9 +886,11 @@ static int hw_breakpoint_reset_notify(struct notifier_block *self, 
						unsigned long action,

						void *hcpu)

{

	int cpu = (long)hcpu;

	if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE)

		smp_call_function_single(cpu, hw_breakpoint_reset, NULL, 1);

	if ((action & ~CPU_TASKS_FROZEN) == CPU_ONLINE) {

		local_irq_disable();

		hw_breakpoint_reset(NULL);

		local_irq_enable();

	}

	return NOTIFY_OK;

}