Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4adf7bf7 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: net: max MTU off by one 



The latest max_mtu patch missed that datagram_size is actually one less
than the datagram's Total Length.

Fixes: 357f4aae ("firewire: net: really fix maximum possible MTU")
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent bebc6082

drivers/firewire/net.c

+6 −1
Original line number Diff line number Diff line
@@ -1480,9 +1480,14 @@ static int fwnet_probe(struct fw_unit *unit, 
		goto out;

	dev->local_fifo = dev->handler.offset;



	/*

	 * default MTU: RFC 2734 cl. 4, RFC 3146 cl. 4

	 * maximum MTU: RFC 2734 cl. 4.2, fragment encapsulation header's

	 *              maximum possible datagram_size + 1 = 0xfff + 1

	 */

	net->mtu = 1500U;

	net->min_mtu = ETH_MIN_MTU;

	net->max_mtu = 0xfff;

	net->max_mtu = 4096U;



	/* Set our hardware address while we're at it */

	ha = (union fwnet_hwaddr *)net->dev_addr;