Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a4e4438 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

bcache: Add __printf annotation to __bch_check_keys() 



Make it possible for the compiler to verify the consistency of the
format string passed to __bch_check_keys() and the arguments that
should be formatted according to that format string.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: default avatarMichael Lyle <mlyle@lyle.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fd01991d

drivers/md/bcache/bset.h

+3 −2
Original line number Original line Diff line number Diff line
@@ -531,14 +531,15 @@ int __bch_keylist_realloc(struct keylist *, unsigned); 
#ifdef CONFIG_BCACHE_DEBUG

#ifdef CONFIG_BCACHE_DEBUG





int __bch_count_data(struct btree_keys *);

int __bch_count_data(struct btree_keys *);

void __bch_check_keys(struct btree_keys *, const char *, ...);

void __printf(2, 3) __bch_check_keys(struct btree_keys *, const char *, ...);

void bch_dump_bset(struct btree_keys *, struct bset *, unsigned);

void bch_dump_bset(struct btree_keys *, struct bset *, unsigned);

void bch_dump_bucket(struct btree_keys *);

void bch_dump_bucket(struct btree_keys *);





#else

#else





static inline int __bch_count_data(struct btree_keys *b) { return -1; }

static inline int __bch_count_data(struct btree_keys *b) { return -1; }

static inline void __bch_check_keys(struct btree_keys *b, const char *fmt, ...) {}

static inline void __printf(2, 3)

	__bch_check_keys(struct btree_keys *b, const char *fmt, ...) {}

static inline void bch_dump_bucket(struct btree_keys *b) {}

static inline void bch_dump_bucket(struct btree_keys *b) {}

void bch_dump_bset(struct btree_keys *, struct bset *, unsigned);

void bch_dump_bset(struct btree_keys *, struct bset *, unsigned);