Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49b12aea authored by Stefan Agner's avatar Stefan Agner Committed by Greg Kroah-Hartman
Browse files

cpufeature: avoid warning when compiling with clang 



[ Upstream commit c785896b21dd8e156326ff660050b0074d3431df ]

The table id (second) argument to MODULE_DEVICE_TABLE is often
referenced otherwise. This is not the case for CPU features. This
leads to warnings when building the kernel with Clang:
  arch/arm/crypto/aes-ce-glue.c:450:1: warning: variable
    'cpu_feature_match_AES' is not needed and will not be emitted
    [-Wunneeded-internal-declaration]
  module_cpu_feature_match(AES, aes_init);
  ^

Avoid warnings by using __maybe_unused, similar to commit 1f318a8b
("modules: mark __inittest/__exittest as __maybe_unused").

Fixes: 67bad2fd ("cpu: add generic support for CPU feature based module autoloading")
Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
Acked-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0abe78e6

include/linux/cpufeature.h

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ 
 * 'asm/cpufeature.h' of your favorite architecture.

 */

#define module_cpu_feature_match(x, __initfunc)			\

static struct cpu_feature const cpu_feature_match_ ## x[] =	\

static struct cpu_feature const __maybe_unused cpu_feature_match_ ## x[] = \

	{ { .feature = cpu_feature(x) }, { } };			\

MODULE_DEVICE_TABLE(cpu, cpu_feature_match_ ## x);		\

								\