Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4936e352 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller
Browse files

bpf: minor cleanups in ebpf code 



Besides others, remove redundant comments where the code is self
documenting enough, and properly indent various bpf_verifier_ops
and bpf_prog_type_list declarations. Moreover, remove two exports
that actually have no module user.

Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 553eb544

kernel/bpf/core.c

+0 −2
Original line number Diff line number Diff line
@@ -129,14 +129,12 @@ struct bpf_prog *bpf_prog_realloc(struct bpf_prog *fp_old, unsigned int size, 


	return fp;

}

EXPORT_SYMBOL_GPL(bpf_prog_realloc);



void __bpf_prog_free(struct bpf_prog *fp)

{

	kfree(fp->aux);

	vfree(fp);

}

EXPORT_SYMBOL_GPL(__bpf_prog_free);



#ifdef CONFIG_BPF_JIT

struct bpf_binary_header *

net/core/filter.c

+15 −19
Original line number Diff line number Diff line
@@ -2069,16 +2069,12 @@ tc_cls_act_func_proto(enum bpf_func_id func_id) 


static bool __is_valid_access(int off, int size, enum bpf_access_type type)

{

	/* check bounds */

	if (off < 0 || off >= sizeof(struct __sk_buff))

		return false;



	/* disallow misaligned access */

	/* The verifier guarantees that size > 0. */

	if (off % size != 0)

		return false;



	/* all __sk_buff fields are __u32 */

	if (size != 4)

	if (size != sizeof(__u32))

		return false;



	return true;