Commit 489e5d41 authored Oct 21, 2015 by Julia Lawall Committed by Stephen Boyd Oct 21, 2015

clk: imx31: add missing of_node_put

for_each_compatible_node performs an of_node_get on each iteration, so a
break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression e;
@@

 for_each_compatible_node(n,...) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

parent 77cb8ee6

drivers/clk/imx/clk-imx31.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -233,9 +233,11 @@ int __init mx31_clocks_init_dt(void)
	if (!of_device_is_compatible(np, "fsl,imx-osc26m"))		if (!of_device_is_compatible(np, "fsl,imx-osc26m"))
	continue;		continue;

	if (!of_property_read_u32(np, "clock-frequency", &fref))		if (!of_property_read_u32(np, "clock-frequency", &fref)) {
			of_node_put(np);
	break;		break;
	}		}
			}

	_mx31_clocks_init(fref);		_mx31_clocks_init(fref);